Adding Installer Telemetry#373
Conversation
|
Hi @sanyamc-msft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@sanyamc-msft, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
There was a problem hiding this comment.
Add copyright headers to all new files.
First set of telemetry infrastructure changes
There was a problem hiding this comment.
Deleting the entire file seems like overkill - all I was saying is not to change the above version string 😃
|
As we just discussed, this is good to go once...
|
|
It would also make merging quicker if you update the PR with the latest changes from NTVS since it's out of date now. |
|
I have resolved all the issues
I will sync with latest NTVS and submit PR for merge. Details on why it wasn't including telemetryaction.dll:
|
…so should be signed automatically
|
Thanks! I'll merge this in, kick of a build, and make sure everything is looking good. |
|
The only comment I had was to make sure the |
Adding a Custom Action to send back installer telemetry using http POST.